Fix Cashier migration order for new installations#1818
Closed
JaiveerChavda wants to merge 1 commit intolaravel:16.xfrom
Closed
Fix Cashier migration order for new installations#1818JaiveerChavda wants to merge 1 commit intolaravel:16.xfrom
JaiveerChavda wants to merge 1 commit intolaravel:16.xfrom
Conversation
Member
|
Nothing fails for me on a fresh Laravel project, installing Cashier, publishing migrations, and then running them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Cashier’s published migrations can run in the wrong order on fresh installations, causing child or alter migrations to execute before the base tables exist and resulting in migration failures.
On a new project, after publishing Cashier migrations, their filenames may be sorted alphabetically in a way that breaks the intended execution order. This behavior is documented in the following issue:
To ensure deterministic and correct ordering, this change prefixes the published migration filenames with explicit sequence markers (
_1,_2,_3, …). This guarantees that:This aligns Cashier’s migration behavior with developer expectations and prevents new users from encountering setup failures.