Avoids Stripe error removing metered price from flex sub#1820
Merged
taylorotwell merged 3 commits intolaravel:16.xfrom Feb 9, 2026
Merged
Avoids Stripe error removing metered price from flex sub#1820taylorotwell merged 3 commits intolaravel:16.xfrom
taylorotwell merged 3 commits intolaravel:16.xfrom
Conversation
5 tasks
vrymel
reviewed
Feb 25, 2026
| $item['deleted'] = true; | ||
|
|
||
| if ($price->recurring->usage_type == 'metered') { | ||
| if ($price->recurring->usage_type == 'metered' && $this->usesFlexibleBilling($stripeSubscription)) { |
Contributor
There was a problem hiding this comment.
I think this condition is wrong. What’s expected is that when the billing mode is flexible, clear_usage should not be used. However, this condition is the reverse of that.
With this change, the operation would still fail when calling swapAndInvoice for example.
Contributor
Author
There was a problem hiding this comment.
Good catch, thats my bad, should be ! $this-> ....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised in Issue #1819 and referenced in PR #1772 comment here until PR is merged or alternative support for flexible billing is provided.