[8.x] Behaviour change on assertAttributeDoesntContain#1154
Merged
taylorotwell merged 5 commits intolaravel:8.xfrom Jan 6, 2025
Merged
[8.x] Behaviour change on assertAttributeDoesntContain#1154taylorotwell merged 5 commits intolaravel:8.xfrom
taylorotwell merged 5 commits intolaravel:8.xfrom
Conversation
revert changes on wrong place and add correct changes
remove whitespace
Update test_assert_attribute_does_not_contain to reflect new behaviour.
remove whitespace
flap152
pushed a commit
to flap152/dusk
that referenced
this pull request
Jan 7, 2025
* Update MakesAssertions.php * Update MakesAssertions.php revert changes on wrong place and add correct changes * Update MakesAssertions.php remove whitespace * Update MakesAssertionsTest.php Update test_assert_attribute_does_not_contain to reflect new behaviour. * Update MakesAssertions.php remove whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #1153 for more info.
Removed notNull assertion in MakeAssertions/assertAttributeDoesntContain and added an early return if the attribute is null.
Updated test in tests/Unit/MakeAssertionsTest.php to reflect new behaviour in unit test.