Skip to content

[8.x] do not pause initially while waiting for an element#1179

Closed
pataar wants to merge 1 commit intolaravel:8.xfrom
pataar:patch-1
Closed

[8.x] do not pause initially while waiting for an element#1179
pataar wants to merge 1 commit intolaravel:8.xfrom
pataar:patch-1

Conversation

@pataar
Copy link
Contributor

@pataar pataar commented Oct 31, 2025

Currently the waitFor calls are pausing for $interval before checking that an element is visible. In a lot of cases this pause is obsolete because the element could be visible initially.

Potentially this could speed up many tests where a lot of waitFor calls are done while elements are visible initially.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@pataar
Copy link
Contributor Author

pataar commented Oct 31, 2025

@taylorotwell Will Dusk be going to an EOL state in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants