Skip to content

#625 Add Two Additional Routes#626

Closed
rcravens wants to merge 4 commits intolaravel:1.xfrom
rcravens:rlc_dev
Closed

#625 Add Two Additional Routes#626
rcravens wants to merge 4 commits intolaravel:1.xfrom
rcravens:rlc_dev

Conversation

@rcravens
Copy link

I recently combined Laravel Fortify with Laravel Breeze front-end components. After completing that integration, noticed that there were two routes where I needed to have the ProfileController from Laravel Breeze to manage those routes. It would be nice to add those into Laravel Fortify. Here are the routes:

GET /profile (profile.edit) - to show the profile page for the user
DELETE /profile (profile.destroy) - to delete the user and their profile

Adding these, I believe, "completes" the route list for Fortify.

Adding these changes.

@rcravens
Copy link
Author

If this pull gets accepted, then I can modify my Laravel Breeze pull (laravel/breeze#476) to get rid of the ProfileController class and fully utilize Laravel Fortify routes.

@smares
Copy link

smares commented Nov 29, 2025

Why do you modify existing source files with just code style changes? Stick to the code style of the project.

@rcravens
Copy link
Author

Why do you modify existing source files with just code style changes? Stick to the code style of the project.

My bad. I thought I would knock out this change quickly and pulled it into an environment where I have my own coding styles enabled.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@rcravens
Copy link
Author

I understand.

I won't release this as a package since Laravel Breeze is maintained by the Laravel Team and I would be actively merging in those changes to keep my packaged synced. I don't have the time to take on additional projects right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants