Skip to content

[12.x] Add withHeartbeat method to LazyCollection #56477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 12.x
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/Illuminate/Collections/LazyCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

use ArrayIterator;
use Closure;
use DateInterval;
use DateTimeImmutable;
use DateTimeInterface;
use Generator;
use Illuminate\Contracts\Support\CanBeEscapedWhenCastToString;
Expand Down Expand Up @@ -1750,6 +1752,42 @@ public function values()
});
}

/**
* Run the given callback every time the interval has passed.
*
* @return static<TKey, TValue>
*/
public function withHeartbeat(DateInterval|int $interval, callable $callback)
{
$seconds = is_int($interval) ? $interval : $this->intervalSeconds($interval);

return new static(function () use ($seconds, $callback) {
$start = $this->now();

foreach ($this as $key => $value) {
$now = $this->now();

if (($now - $start) >= $seconds) {
$callback();

$start = $now;
}

yield $key => $value;
}
});
}

/**
* Get the total seconds from the given interval.
*/
protected function intervalSeconds(DateInterval $interval): int
{
$start = new DateTimeImmutable();

return $start->add($interval)->getTimestamp() - $start->getTimestamp();
}

/**
* Zip the collection together with one or more arrays.
*
Expand Down
15 changes: 15 additions & 0 deletions tests/Support/SupportLazyCollectionIsLazyTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1706,6 +1706,21 @@ public function testWhereStrictIsLazy()
});
}

public function testWithHeartbeatIsLazy()
{
$this->assertDoesNotEnumerate(function ($collection) {
$collection->withHeartbeat(1, function () {
// Heartbeat callback
});
});

$this->assertEnumeratesOnce(function ($collection) {
$collection->withHeartbeat(1, function () {
// Heartbeat callback
})->all();
});
}

public function testWrapIsLazy()
{
$this->assertDoesNotEnumerate(function ($collection) {
Expand Down
47 changes: 47 additions & 0 deletions tests/Support/SupportLazyCollectionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -447,4 +447,51 @@ public function testDot()

$this->assertEquals($expected, $dotted->all());
}

public function testWithHeartbeat()
{
$start = Carbon::create(2000, 1, 1);
$after2Minutes = $start->copy()->addMinutes(2);
$after5Minutes = $start->copy()->addMinutes(5);
$after7Minutes = $start->copy()->addMinutes(7);
$after11Minutes = $start->copy()->addMinutes(11);

Carbon::setTestNow($start);

$output = new Collection();

$numbers = LazyCollection::range(1, 10)

// Move the clock to possibly trigger the heartbeat...
->tapEach(fn ($number) => Carbon::setTestNow(
match ($number) {
3 => $after2Minutes,
4 => $after5Minutes,
6 => $after7Minutes,
9 => $after11Minutes,
default => Carbon::now(),
}
))

// Push the current date to `output` when heartbeat is triggered...
->withHeartbeat(Duration::minutes(5), fn () => $output[] = Carbon::now())

// Push every number onto `output` as it's enumerated...
->tapEach(fn ($number) => $output[] = $number)->all();

$this->assertEquals(range(1, 10), $numbers);

$this->assertEquals(
[
1, 2, 3,
$after5Minutes,
4, 5, 6, 7, 8,
$after11Minutes,
9, 10,
],
$output->all(),
);

Carbon::setTestNow();
}
}