[13.x] Add RouteKey and BindRoute attributes for route model binding#59020
Draft
Tresor-Kasenda wants to merge 2 commits intolaravel:13.xfrom
Draft
[13.x] Add RouteKey and BindRoute attributes for route model binding#59020Tresor-Kasenda wants to merge 2 commits intolaravel:13.xfrom
Tresor-Kasenda wants to merge 2 commits intolaravel:13.xfrom
Conversation
Contributor
|
While I think that
|
Member
|
Agree I would remove the BindRoute stuff. |
Contributor
Author
|
Thanks for the feedback. I also agree that a generic scope-based approach would be preferable over a soft-delete-specific withTrashed. |
Contributor
Author
|
@taylorotwell I can delete that and make another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds first-class PHP attribute metadata for implicit route model binding:
#[RouteKey('field')]on Eloquent models#[BindRoute(parameter: ..., field: ..., withTrashed: ...)]on route parametersThis PR add :
getRouteKeyName()use cases.Before / After
1) Model route key convention (
RouteKey)Before
After
2) Per-parameter binding metadata (
BindRoute)Before
After