[13.x] Correctly handle route parameters with defaults and key binding#59128
Draft
alaminfirdows wants to merge 1 commit intolaravel:masterfrom
Draft
[13.x] Correctly handle route parameters with defaults and key binding#59128alaminfirdows wants to merge 1 commit intolaravel:masterfrom
alaminfirdows wants to merge 1 commit intolaravel:masterfrom
Conversation
Member
|
Does it work if you do |
Author
Yes! Both |
Member
|
No I mean does the current code on 12.x work for you if you just do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is a follow-up to the previous discussion where @crynobone suggested that the change should be submitted against the
masterbranch instead of the 12.x patch branch.Description:
This PR fixes an issue where
URL::defaults()combined with route parameters (including model key binding fields) causes positional parameter misalignment when generating URLs withroute()call.Problem:
When a route defines a parameter with a key binding (e.g.,
{team:slug}) and a default is set using only the parameter name (e.g.,URL::defaults(['team' => 'example-team']);), the default does not correctly align with the bound field (slug).As a result, calling
route()with positional or named parameters can incorrectly assign values, producing an empty query string like<URL>?team=instead of the expected URL.Reference: #57488
Solution:
Added a check for both named parameters and key binding fields to correctly align route parameters when generating URLs.
Example: