[13.x] Ensure ScopedBy Attribute works with inheritance#59332
Merged
taylorotwell merged 1 commit intolaravel:13.xfrom Mar 23, 2026
Merged
[13.x] Ensure ScopedBy Attribute works with inheritance#59332taylorotwell merged 1 commit intolaravel:13.xfrom
taylorotwell merged 1 commit intolaravel:13.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
6c8a3cc to
166d52b
Compare
ensure it works with inheritence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ObservedByattribute works with inheritance, butScopedBydoesnt.This PR fixes that.
This is a B/C, but arguably expected behavior IMO, if you did this the booted() way, it would work like this PR.
The code is pretty much a copy paste of what
ObservedBydoes no lieHappy to target master, but thought I'd try 13.x first 🫡 Not sure if it needs porting back too
Example: