[5.x] Fix runaway memory usage with horizon:listen#1716
Merged
taylorotwell merged 1 commit intolaravel:5.xfrom Feb 25, 2026
Merged
[5.x] Fix runaway memory usage with horizon:listen#1716taylorotwell merged 1 commit intolaravel:5.xfrom
horizon:listen#1716taylorotwell merged 1 commit intolaravel:5.xfrom
Conversation
Contributor
Author
|
@saifali-dev would you want to make this change locally and confirm it works for you? |
|
Thanks @cosmastech. I tested the PR locally ( |
lewislarsen
pushed a commit
to lewislarsen/horizon
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #1715
So it turns out that calling Symfony's Process with an array vs a string produces different behavior. Who knew? It seems that by passing a string, it calls
sh <command>rather thanexec <command>and the PID belongs to the sh process, not the actual command. Killing that process doesn't kill the underlying supervisor + workers.Note that the identified problem doesn't appear to be an issue on bare metal on my MBP. However, inside of a docker container, big sadness.