return exit code from terminate command#1718
Merged
taylorotwell merged 2 commits intolaravel:5.xfrom Feb 27, 2026
Merged
Conversation
lewislarsen
pushed a commit
to lewislarsen/horizon
that referenced
this pull request
Mar 2, 2026
* return exit code from terminate command * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
horizon:terminatereturns an error, the command still exits with the defaultstatusCode = 0, which indicates success.As a result, automation scripts such as Deployer do not report a failure and instead mark the step as successful.
The problem occurs, for example, when the queue is running under a different user than the one attempting to restart it. In that case, we receive the message:
However, Deployer still treats this as a success and continues the deployment process, even though the code has not actually been updated because the queue was not restarted.