-
Notifications
You must be signed in to change notification settings - Fork 206
Modernize Flux usage #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Modernize Flux usage #143
Conversation
|
as collapsible sidebars was changed in v2.3.0, you should also update the min-version in composer.json to ^2.3.0 |
|
Good call, @hebbet - Ended up updating it to ^2.3.2 as 2.3.1 had a bug with the sidebar toggle. |
39cc003 to
bda3660
Compare
|
Is this PR ready for Livewire 4? |
|
@nisbeti Not exactly. Flux version 2.6.1 supports Livewire 4. This PR requires only Flux version 2.3.2. (I would not be opposed to doing the work to update Flux versions, but it goes beyond the scope of what I wanted to accomplish in this PR) |
Thank you. If you do decide to do the work, please drop a link here, so we can show it some love and start our new projects with a completely modern look and feel. |
Flux UI has had some updates since this starter kit was written. Specifically, we've got some new elements, and some deprecated APIs. Within this PR, I seek to update the usage of Flux components, to make sure we're staying up to date with changes, while minimizing any visual or functional changes to existing starter kit layout.
A high level overview of the changes is as follows:
flux:brandcomponentstashableAPI onflux:sidebar, in favor of the newcollapsible="mobile"API.desktop-user-menu.blade.phpto remove around 30 lines of nearly identical code from the header and sidebar layoutsflux:navlistcomponents within the sidebar with the newerflux:sidebar.navcomponentsAgain, these changes should not significantly alter the functionality or design of the starter kit, but they do bring us more in line with the latest versions of Flux.