feat: Allow findForPassport to optionally receive the OAuth client#1866
Merged
taylorotwell merged 6 commits intolaravel:13.xfrom Oct 26, 2025
Merged
feat: Allow findForPassport to optionally receive the OAuth client#1866taylorotwell merged 6 commits intolaravel:13.xfrom
findForPassport to optionally receive the OAuth client#1866taylorotwell merged 6 commits intolaravel:13.xfrom
Conversation
Refactor user retrieval logic to use ReflectionMethod for dynamic argument handling.
findForPassport to optionally receive the OAuth client
Contributor
hafezdivandari
left a comment
There was a problem hiding this comment.
No need to use reflection, just pass the $clientEntity as argument. If you want to make this change, please apply the same to line 38:
- $user = (new $model)->findAndValidateForPassport($username, $password);
+ $user = (new $model)->findAndValidateForPassport($username, $password, $clientEntity);Co-authored-by: Hafez Divandari <hafezdivandari@gmail.com>
Contributor
Author
|
@hafezdivandari updated ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Laravel Passport uses the
findForPassport(string $username)method to retrieve the user during password grant authentication. This method only receives the username, which limits cases where we might want to filter users based on the OAuth client.This PR introduces the possibility to define
findForPassportwith a second optional parameter, aClientEntityInterface $client, allowing:Example usage:
This is not a breaking change: existing methods with a single parameter will continue to work.
📖 I also prepared a PR for the documentation to explain this new possibility: laravel/docs#10880