Show a default error message when the middleware check fails#141
Merged
taylorotwell merged 3 commits intolaravel:1.xfrom Jun 2, 2025
Merged
Show a default error message when the middleware check fails#141taylorotwell merged 3 commits intolaravel:1.xfrom
taylorotwell merged 3 commits intolaravel:1.xfrom
Conversation
Member
|
I don't love that this will expose feature names in a non-debug environment. An API response, for example, will show the feature names: 
|
Member
|
Yeah, maybe need an environment check here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
EnsureFeaturesAreActivemiddleware, you may see errors like this, which aren't super helpful.Before
After
I'll add a test for this if desired.