Fix - Correct retrieval of 0 feature values via DB driver#143
Merged
taylorotwell merged 1 commit intolaravel:1.xfrom Jul 7, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for Issue #142
When a stored value for a feature is
0(JSON"0"),$filtered->value('value')internally makes a loose comparison of"0" == true, resulting in no matches being found.nullis then passed intojson_decode(), triggering the following:Issue was reproduced with tests pre-solve.
The fix assumes that if
$filteredhas records which match the provided$featureand$scopeit can just grab the value directly from->first()- that would typically have one result I believe.