Skip to content

Conversation

@ijpatricio
Copy link

This PR replaces running ./vendor/bin/phpunit with the set up Pest ./vendor/bin/pest

image

This PR replaces running `./vendor/bin/phpunit` with the set up Pest `./vendor/bin/pest`
@tnylea
Copy link
Contributor

tnylea commented Feb 25, 2025

Hey @ijpatricio 👋

How's everything going? Thanks for the PR. So, each of the starter kits is using PHPUnit by default, but we have the ability to use Pest.

When you install Pest via the Laravel installer, it actually runs the Pest Drift Plugin (https://github.com/pestphp/pest-plugin-drift), which converts PHPUnit to Pest.

If you are using Pest with your app that you've built with the starter kit, you will probably want to replace ./vendor/bin/phpunit with ./vendor/bin/pest, but I don't believe we want to modify that here, unless I'm missing something.

Let me know. Thanks!

@ijpatricio
Copy link
Author

I overlooked this, somehow.

CI in this repo is unable to run Pest, and it runs PHPUnit in the pipeline, all good.

I came to fix this because after installing the starter kit, I got reversed results: I'm not able to run PHPUnit, but Pest yes.

@ijpatricio
Copy link
Author

Hey @ijpatricio 👋

How's everything going? Thanks for the PR. So, each of the starter kits is using PHPUnit by default, but we have the ability to use Pest.

When you install Pest via the Laravel installer, it actually runs the Pest Drift Plugin (https://github.com/pestphp/pest-plugin-drift), which converts PHPUnit to Pest.

If you are using Pest with your app that you've built with the starter kit, you will probably want to replace ./vendor/bin/phpunit with ./vendor/bin/pest, but I don't believe we want to modify that here, unless I'm missing something.

Let me know. Thanks!

Hey @tnylea 👋 Doing well, yourself?!

Yes, spot on! Just now I understand what's going on, with your explanation!

After installation, I got a failed CI.

So that might be right, but I have this feeling it should be ready when someone installs.

Not complaining, only stating how we devs are "spoiled" nowadays :)

CleanShot 2025-02-25 at 00 27 43

@ijpatricio
Copy link
Author

If you are using Pest with your app that you've built with the starter kit, you will probably want to replace
./vendor/bin/phpunit with ./vendor/bin/pest, but I don't believe we want to modify that here, unless I'm missing something.

In hindsight, I think that when I choose Pest, it would be a nice touch to have the action file contentes replaced as well.

I don't want to sound picky, or something, I really appreciate all the effort and output you're putting out there!

Do let me know if a PR to laravel/installer for replacing run: ./vendor/bin/phpunit by run: ./vendor/bin/pest would be a good fit, I can totally contribute that.

Closing the PR, because indeed it doesn't make sense!

@ijpatricio ijpatricio closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants