Skip to content

Conversation

@impruthvi
Copy link
Contributor

This PR replaces hardcoded URLs with Laravel's route() helper function across various components, layouts, and tests. This change improves maintainability, ensuring routes remain dynamic and consistent even if route definitions change in the backend.

Changes

  • Updated navigation links in AppHeader, AppSidebar, and settings/layout.tsx to use route() instead of hardcoded URLs.
  • Modified breadcrumbs and sidebar navigation to reference named routes.
  • Updated feature tests in DashboardTest.php to use route() for better accuracy and consistency.

@crynobone crynobone self-requested a review February 25, 2025 12:46
@taylorotwell
Copy link
Member

Going to table this for now until dust settles a bit.

@impruthvi
Copy link
Contributor Author

@taylorotwell
Understood! Let me know if there's anything I can do or if any changes are needed when you're ready to revisit this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants