ESLint #5
Merged
ESLint #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avosalmon
commented
Feb 5, 2025
|
|
||
| export default function SettingsLayout({ children }: { children: React.ReactNode }) { | ||
| const currentPath = window.location.pathname; | ||
| const currentItem = sidebarNavItems.find((item) => currentPath === item.url); |
Author
There was a problem hiding this comment.
@tnylea ESLint complained because currentItem is not used. Any plans to use it?
Contributor
There was a problem hiding this comment.
You're right! currentItem is not needed as currentPath is what we need to show an active state for the current setting menu item. I'll get this merged in today 👏 Thanks!
Author
|
I wonder if we should run PHPStan, Pint, ESLint, and Prettier on CI to catch and fix issues before merging a PR. |
Contributor
I'm going to work on that today! This would be great to add as an action that automatically runs when someone pushes new code. Thanks again for this PR. Getting it merged in now 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npm run lintthrows an error because the ESLint config file does not exist.This PR adds an ESLint flat config file (the new config system introduced in ESLint 9) and fixes some lint errors.
I have added the following plugins
eabc060 fixes the lint errors below.