-
Notifications
You must be signed in to change notification settings - Fork 310
Fix Inertia SSR errors #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
taylorotwell
merged 13 commits into
laravel:main
from
JoeyMckenzie:fix/inertia-ssr-errors
Mar 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bddd3f6
fix: check for window when running ssr
JoeyMckenzie bb24863
chore: remove ssr files
JoeyMckenzie 3e7b127
fix: add ziggy to inertia middleware for ssr
JoeyMckenzie 4e292f7
chore: remove bootstrap ssr
JoeyMckenzie 011ee04
chore: add script for ssr
JoeyMckenzie 689d780
chore: merge main, resolve conflicts
JoeyMckenzie 4951bcd
chore: update composer script
JoeyMckenzie 0039931
Adding solution for Dark Mode flicker with SSR
tnylea 51059af
Adding condition for system appearance and detecting via client-side …
tnylea cf70d5e
Merge branch 'laravel:main' into fix/inertia-ssr-errors
JoeyMckenzie b11cf1e
feat: add inline style to prevent flash during CSR
JoeyMckenzie 09dad2e
formatting
taylorotwell c1a0fcf
package update
taylorotwell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,4 @@ yarn-error.log | |
/.nova | ||
/.vscode | ||
/.zed | ||
/bootstrap/ssr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is url in usePage hooks, why not just use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We certainly could, both will accomplish the same thing I'm pretty sure. This is just a preference of being explicit about rendering on the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in that context I prefer that way too, thanks for the answer.