Skip to content

fix(logout)!: clear Inertia prefetch cache on logout to prevent data leakage #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix(logout)!: clear Inertia prefetch cache on logout to prevent data leakage #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions resources/js/components/user-menu-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { DropdownMenuGroup, DropdownMenuItem, DropdownMenuLabel, DropdownMenuSep
import { UserInfo } from '@/components/user-info';
import { useMobileNavigation } from '@/hooks/use-mobile-navigation';
import { type User } from '@/types';
import { Link } from '@inertiajs/react';
import { Link, router } from '@inertiajs/react';
import { LogOut, Settings } from 'lucide-react';

interface UserMenuContentProps {
Expand All @@ -12,6 +12,11 @@ interface UserMenuContentProps {
export function UserMenuContent({ user }: UserMenuContentProps) {
const cleanup = useMobileNavigation();

const handleLogout = () => {
cleanup();
router.flushAll();
};

return (
<>
<DropdownMenuLabel className="p-0 font-normal">
Expand All @@ -30,7 +35,7 @@ export function UserMenuContent({ user }: UserMenuContentProps) {
</DropdownMenuGroup>
<DropdownMenuSeparator />
<DropdownMenuItem asChild>
<Link className="block w-full" method="post" href={route('logout')} as="button" onClick={cleanup}>
<Link className="block w-full" method="post" href={route('logout')} as="button" onClick={handleLogout}>
<LogOut className="mr-2" />
Log out
</Link>
Expand Down