Fixes inconsistency in Sanctum::currentApplicationUrlWithPort() and Sanctum::currentRequestHost()#565
Merged
taylorotwell merged 2 commits intolaravel:4.xfrom Apr 23, 2025
denjaland:4.x
Merged
Fixes inconsistency in Sanctum::currentApplicationUrlWithPort() and Sanctum::currentRequestHost()#565taylorotwell merged 2 commits intolaravel:4.xfrom denjaland:4.x
taylorotwell merged 2 commits intolaravel:4.xfrom
denjaland:4.x
Conversation
…) and Sanctum::currentRequestHost() work in a similar way by prepending the url or placeholder with a comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When submitting #564, I didn't include a test using the actual config file.
Pulling in the new version to day, I noticed there was an issue with using it in the config as follows:
The problem is, that
Sanctum::currentApplicationUrlWithPort()prepends the url with a comma, so it can be used here in the config.personally, I don't like the prepend for the sake of making it usable in the
explode(sprintf())here, and would remove it, but that would be a breaking change, so I changed the implementation of theSanctum::currentRequestHost()to be in line with howSanctum::currentApplicationUrlWithPort()works, so this can be used in the same way.My apologies for the oversight.