Refactor: Extract Frontend Request Checking Logic#569
Closed
StarkOne wants to merge 3 commits intolaravel:4.xfrom
StarkOne:refactor/frontend-request-checker
Closed
Refactor: Extract Frontend Request Checking Logic#569StarkOne wants to merge 3 commits intolaravel:4.xfrom StarkOne:refactor/frontend-request-checker
StarkOne wants to merge 3 commits intolaravel:4.xfrom
StarkOne:refactor/frontend-request-checker
Conversation
… improve its structure and adhere more closely to the Single Responsibility Principle.
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
EnsureFrontendRequestsAreStatefulmiddleware to improve its structure and adhere more closely to the Single Responsibility Principle.Description
The
EnsureFrontendRequestsAreStatefulmiddleware was previously responsible for two distinct tasks:This refactor extracts the domain-checking logic into its own dedicated class,
FrontendRequestChecker. This simplifies the middleware, making its sole responsibility to orchestrate the middleware pipeline.Changes Made
Laravel\Sanctum\Http\Middleware\FrontendRequestCheckerclass.statefulconfiguration fromEnsureFrontendRequestsAreStateful::fromFrontend()to the newFrontendRequestChecker::isFromFrontend()method.EnsureFrontendRequestsAreStatefulmiddleware now calls the new checker class. Its internal static methodfromFrontend()has been removed.Benefits of this Change
FrontendRequestCheckercan now be unit-tested in complete isolation, leading to simpler and more robust tests.