Use Algolia's filters parameter instead of numericFilters for string filter support#971
Closed
alecgarcia wants to merge 1 commit intolaravel:10.xfrom
Closed
Conversation
…ter types
The numericFilters parameter only supports numeric values, causing string-based
filters (e.g. whereNotIn('status', ['deleted'])) to fail. This migrates all
filtering to the unified filters parameter, which supports both numeric
comparisons and facet/string matching using proper Algolia filter syntax.
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Hey there - I think it would be better to look at this on |
Author
|
@taylorotwell I will look at the changes in |
Author
|
Looks like commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numericFiltersparameter to the unifiedfiltersparameter, which supports both numeric comparisons and facet/string matchingwhereNotIn('status', ['deleted'])) which previously failed becausenumericFiltersonly accepts numeric valueskey=valuefor numeric,key:"value"for strings,NOT key:"value"for string negation,(... OR ...)for whereIn groups, joined withANDTest plan
Made with Cursor