Skip to content

Conversation

putrafajarh
Copy link

@putrafajarh putrafajarh commented Apr 9, 2025

Screenshot 2025-04-10 at 00 13 52

Previously, the input focus wasn't working correctly when:

  1. Deleting a user
  2. Changing a password

This commit also replaced user ref with Vue 3.5+'s useTemplateRef

@chabdulrahmn
Copy link

Hey @putrafajarh,

Just wanted to share that i had also worked on a similar fix earlier in PR #54 (which was closed due to my unavailability at the time). I've now rebased and reopened my version with a cleaner approach that avoids both $el and ref entirely, using direct access via formElement.password.

If you're interested, you can check out my updated PR here: #124

@putrafajarh
Copy link
Author

Thanks @chabdulrahmn

@tnylea
Copy link
Contributor

tnylea commented Apr 25, 2025

Appreciate the PR. We are going to be mergeing in #124 here shortly which will accomplish the same thing. He previously had another PR in the works that accomplished this, which was before this PR.

Either way, they both accomplish the same thing. Appreciate the contribution 🙏

@tnylea tnylea closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants