fix:resend-api-key-service-config-updated #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably be fixed at laravel/laravel but ultimately it's a user configured value and can be anything you want. |
pushpak1300
added a commit
that referenced
this pull request
Aug 19, 2025
taylorotwell
added a commit
that referenced
this pull request
Sep 10, 2025
* feat: implement two-factor authentication functionality and UI enhancements (#147) * refactor: extract two-factor authentication logic to composable for better reusability and cleanup (#148) * refactor: move two-factor authentication logic from composable to page component and simplify implementation logic (#149) * refactor: simplify two-factor authentication logic with form components and improve conditional rendering * feat: add PinInput component and update TwoFactor UI with reka-ui 2.4.1 enhancements * refactor: replace reka-ui PinInput with custom implementation and optimize TwoFactor UI components * refactor: revert unneeded changes * refactor: simplify two-factor authentication * feat: update two-factor authentication to delay login until confirmation * wip * wip * refactor: centralize two-factor authentication logic, improve UI state and * refactor: streamline TwoFactor components, simplify form handling, and improve UI logic consistency * refactor: centralize clipboard and two-factor authentication logic, enhance state management, and optimize TwoFactor UI components * refactor: enhance TwoFactor UI components with reusable Card layout, improve recovery codes visibility toggle, and standardize spacing * fix: use `hasEnabledTwoFactorAuthentication` for improved logic clarity in session handling * refactor: streamline TwoFactor UI logic, improve recovery mode toggle, and standardize naming conventions * refactor: simplify TwoFactor test structure, replace manual assertions with Inertia assertions, and improve naming consistency * chore: add newline to end of TwoFactorAuthenticationTest file * refactor: enhance TwoFactor UI with conditional enable button logic, refine recovery codes handling * refactor: enhance TwoFactor UI with conditional enable button logic, refine recovery codes handling * refactor: inline two-factor authentication composable logic into TwoFactor component to simplify structure * refactor: remove unused `ref` and `focus` logic from Input component to simplify structure * refactor: enhance two-factor authentication flow with middleware checks, improved UI spacing, and expanded test coverage * refactor: simplify TwoFactor component with async/await, refine recovery codes handling, and standardize UI consistency * refactor: reset setup data on modal close, improve form handling, and simplify PinInput structure * refactor: add reusable reset methods for reactive states, simplify TwoFactor logic, and enhance PinInput handling * fix: formatting issue * fix: conditionally apply password confirmation middleware * chore: update lock file * fix: make component reactive * wip * refactor: split the component * refactor: use composable * refactor: remove redundant type definition * refactor: remove custom useClipboard composable * refactor: simplify recovery codes visibility logic * fix: merge issues * refactor: update two-factor authentication forms to use route helpers * refactor: test * refactor: improve two-factor authentication tests and enhance readability * refactor: update two-factor authentication tests for consistency and improve code readability * wip * Move conditional middleware from route to controller * Fix tests to be consistent based on config * Remove comments * refactor: simplify toggleRecoveryCodesVisibility function signature * remove duplicate type defination * fix type definition * More Fixes * fix types * fix wayfinder routes * refactor ui to use defineModal and remove unnecessary things * remove unneeded async attribute * remove redundant attribute action * fix: finish state * fix: merge conflicts * state cleanup * fix typo * use arrow functions * Move trait to form-request * Formatting * various formatting tweaks * Update TwoFactorSetupModal.vue * Bump Fortify * Use ensure state is valid from Fortify * Refactor TwoFactorAuthenticationRequest namespace * Formatting * Formatting * Refactor Test * formatting * Fix Text Jarring Issue * Add hasSetupData to avoid enabling 2FA again * Update useTwoFactorAuth.ts --------- Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resend Docs: https://resend.com/docs/send-with-laravel#2-configuration