Skip to content

Update Settings Layout- Remove y spacing and update break for Separator #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Update Settings Layout- Remove y spacing and update break for Separator #165

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a56e1cd
Update Settings Layout- Remove y spacing and update break for Separator
cwray-tech Jul 17, 2025
1ad870e
Update resources/js/layouts/settings/Layout.vue
cwray-tech Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/js/layouts/settings/Layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const currentPath = page.props.ziggy?.location ? new URL(page.props.ziggy.locati
<div class="px-4 py-6">
<Heading title="Settings" description="Manage your profile and account settings" />

<div class="flex flex-col space-y-8 md:space-y-0 lg:flex-row lg:space-y-0 lg:space-x-12">
<div class="flex flex-col lg:flex-row lg:space-y-0 lg:space-x-12">
<aside class="w-full max-w-xl lg:w-48">
<nav class="flex flex-col space-y-1 space-x-0">
Copy link

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using Tailwind's gap utilities (e.g., gap-y-6 lg:gap-x-12) instead of separate space- classes and an explicit Separator for spacing consistency and cleaner markup.

Suggested change
<div class="flex flex-col lg:flex-row lg:space-y-0 lg:space-x-12">
<aside class="w-full max-w-xl lg:w-48">
<nav class="flex flex-col space-y-1 space-x-0">
<div class="flex flex-col lg:flex-row gap-y-6 lg:gap-x-12">
<aside class="w-full max-w-xl lg:w-48">
<nav class="flex flex-col gap-y-1">

Copilot uses AI. Check for mistakes.

<Button
Expand All @@ -46,7 +46,7 @@ const currentPath = page.props.ziggy?.location ? new URL(page.props.ziggy.locati
</nav>
</aside>

<Separator class="my-6 md:hidden" />
<Separator class="my-6 lg:hidden" />

<div class="flex-1 md:max-w-2xl">
<section class="max-w-xl space-y-12">
Expand Down