Remove TSX from components.json #170
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The schema for shadcn and shadcn-vue has differing lines for typescript. - shadcn-vue uses typescript - shadcn uses tsx. - However if setting typescript to false, there is an error when adding components via CLI, this makes the setting redundant as it's true by default - To avoid compatibility removing this lines fixes compatibility and also allows generation of components to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @patrickdundas highlighted in #166, the transition from
typescripttotsxin the vue-starter-kit has introduced an issue that breaks the ability to add components via the CLI.Upon further investigation, @patrickdundas found that the root of the issue lies in how components.json is handled differently between the shadcn and shadcn-vue packages:
shadcn-vue defaults to using
typescriptin its schema.shadcn, on the other hand, defaults to
tsx.When reverting the
tsxsetting back to thetypescriptand setting it to true, component generation works as expected, but not for 3rd party plugins. However, if you then attempt to set typescript to false, it breaks the generation process again.This makes the setting somewhat redundant, as both
tsxandtypescriptare enabled by default, and neither can reliably be set to false without causing issues.Removing the explicit line for typescript (
tsx) resolves the incompatibility between the two schema implementations and restores full CLI support for component generation, including compatibility with third-party plugins.This change ensures consistency and prevents unexpected behaviour regardless of which underlying schema is used.