Skip to content

Feature/accessibility improvements #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/accessibility improvements #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec0408a
Adds a skip link to the app layout
movntains Sep 19, 2025
fff1ac3
Adds missing H1s to settings pages
movntains Sep 19, 2025
80172aa
Adds ARIA label to settings navigation
movntains Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions resources/js/components/AppContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const className = computed(() => props.class);
</SidebarInset>
<main
v-else
id="main"
class="mx-auto flex h-full w-full max-w-7xl flex-1 flex-col gap-4 rounded-xl"
:class="className"
>
Expand Down
9 changes: 9 additions & 0 deletions resources/js/components/AppSkipLink.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<template>
<a
href="#main"
class="absolute -top-14 left-4 z-[100] rounded-md bg-black px-4 py-2 text-sm font-semibold text-white shadow-lg transition-all duration-300 ease-in-out focus:top-2 focus:outline-2 focus:ring-primary-500 focus:outline-offset-4 dark:bg-primary dark:text-black dark:focus:outline-sidebar-ring motion-reduce:transition-none"
>
Skip to Main Content
</a>
</template>

1 change: 1 addition & 0 deletions resources/js/components/ui/sidebar/SidebarInset.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const props = defineProps<{

<template>
<main
id="main"
data-slot="sidebar-inset"
:class="cn(
'bg-background relative flex w-full flex-1 flex-col',
Expand Down
2 changes: 2 additions & 0 deletions resources/js/layouts/AppLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script setup lang="ts">
import AppLayout from '@/layouts/app/AppSidebarLayout.vue';
import AppSkipLink from '@/components/AppSkipLink.vue';
import type { BreadcrumbItemType } from '@/types';

interface Props {
Expand All @@ -12,6 +13,7 @@ withDefaults(defineProps<Props>(), {
</script>

<template>
<AppSkipLink />
<AppLayout :breadcrumbs="breadcrumbs">
<slot />
</AppLayout>
Expand Down
2 changes: 1 addition & 1 deletion resources/js/layouts/settings/Layout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const currentPath = typeof window !== undefined ? window.location.pathname : '';

<div class="flex flex-col lg:flex-row lg:space-x-12">
<aside class="w-full max-w-xl lg:w-48">
<nav class="flex flex-col space-y-1 space-x-0">
<nav class="flex flex-col space-y-1 space-x-0" aria-label="Settings">
<Button
v-for="item in sidebarNavItems"
:key="toUrl(item.href)"
Expand Down
2 changes: 2 additions & 0 deletions resources/js/pages/settings/Appearance.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ const breadcrumbItems: BreadcrumbItem[] = [
<AppLayout :breadcrumbs="breadcrumbItems">
<Head title="Appearance settings" />

<h1 class="sr-only">Appearance Settings</h1>

<SettingsLayout>
<div class="space-y-6">
<HeadingSmall
Expand Down
2 changes: 2 additions & 0 deletions resources/js/pages/settings/Password.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const currentPasswordInput = ref<HTMLInputElement | null>(null);
<AppLayout :breadcrumbs="breadcrumbItems">
<Head title="Password settings" />

<h1 class="sr-only">Password Settings</h1>

<SettingsLayout>
<div class="space-y-6">
<HeadingSmall
Expand Down
2 changes: 2 additions & 0 deletions resources/js/pages/settings/Profile.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ const user = page.props.auth.user;
<AppLayout :breadcrumbs="breadcrumbItems">
<Head title="Profile settings" />

<h1 class="sr-only">Profile Settings</h1>

<SettingsLayout>
<div class="flex flex-col space-y-6">
<HeadingSmall
Expand Down
3 changes: 3 additions & 0 deletions resources/js/pages/settings/TwoFactor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ onUnmounted(() => {
<template>
<AppLayout :breadcrumbs="breadcrumbs">
<Head title="Two-Factor Authentication" />

<h1 class="sr-only">Two-Factor Authentication Settings</h1>

<SettingsLayout>
<div class="space-y-6">
<HeadingSmall
Expand Down