Update preview #200
Merged
Update preview #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding initial SSR fixes * fixing warning messages in SSR * Adding updates to ssr file to include global route var * Adding dev:ssr command * Adding light/dark mode fixes to support cookies and localstorage * updating the intertia return array * formatting * run formatter --------- Co-authored-by: Taylor Otwell <[email protected]>
… formatting. (#77) This PR adds a new rule to `.prettierignore` to exclude `resources/views/mail/*` from automatic formatting. Email templates often contain embedded Blade syntax and inline styles, which Prettier's formatting rules can disrupt. Ignoring these files ensures that the email templates' intended structure and formatting remain intact.
* fix: sidebar open position This update aligns the vue-starter-kit with react-starter-kit regarding the sidebar dropdown * Update NavUser.vue --------- Co-authored-by: Taylor Otwell <[email protected]>
Improve Readability of stderr Log Channel Configuration
* Adding tooltips to collapsible sidebar * Update NavMain.vue --------- Co-authored-by: Taylor Otwell <[email protected]>
* fix: use sidebar cookie for state * chore: rename sidebar cookie * Adding update to have sidebar open by default * Update HandleInertiaRequests.php --------- Co-authored-by: Tony Lea <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
Co-authored-by: Tony Lea <[email protected]>
* new attempt at tw4 upgrade * Adding upgrade steps * Adding some final updates * Final touches for V4 upgrade * removing autoprefixer * replacing tailwind-animate with tw-animate-css * updating comments to latest version since last release * removing autoprefixer from dependencies * Delete composer.lock --------- Co-authored-by: Taylor Otwell <[email protected]>
* Adding prefetch to settings and adding logout flush * Update UserMenuContent.vue --------- Co-authored-by: Taylor Otwell <[email protected]>
* fix(sidebar-state): Update sidebar cookie name according to shadcn * fix(sidebar-state): Change sidebar cookie name according to shadcn
* fix(appearance): Remove duplicate initializeTheme call initializeTheme is already called in app.ts * fix(types): Type string is not assignable to type Method | undefined Replaced the generic string type with the Method type from @inertiajs/core for better type safety and alignment with Inertia.js. * fix(sidebar): Fix breadcrumbs rendering Ensure the sidebar only renders breadcrumbs when the `breadcrumbs` object exists and has entries. This prevents potential runtime errors if `breadcrumbs` is null or undefined.
Fix active state logic for sidebar menu items
Signed-off-by: Mior Muhammad Zaki <[email protected]>
* feat: implement two-factor authentication functionality and UI enhancements (#147) * refactor: extract two-factor authentication logic to composable for better reusability and cleanup (#148) * refactor: move two-factor authentication logic from composable to page component and simplify implementation logic (#149) * refactor: simplify two-factor authentication logic with form components and improve conditional rendering * feat: add PinInput component and update TwoFactor UI with reka-ui 2.4.1 enhancements * refactor: replace reka-ui PinInput with custom implementation and optimize TwoFactor UI components * refactor: revert unneeded changes * refactor: simplify two-factor authentication * feat: update two-factor authentication to delay login until confirmation * wip * wip * refactor: centralize two-factor authentication logic, improve UI state and * refactor: streamline TwoFactor components, simplify form handling, and improve UI logic consistency * refactor: centralize clipboard and two-factor authentication logic, enhance state management, and optimize TwoFactor UI components * refactor: enhance TwoFactor UI components with reusable Card layout, improve recovery codes visibility toggle, and standardize spacing * fix: use `hasEnabledTwoFactorAuthentication` for improved logic clarity in session handling * refactor: streamline TwoFactor UI logic, improve recovery mode toggle, and standardize naming conventions * refactor: simplify TwoFactor test structure, replace manual assertions with Inertia assertions, and improve naming consistency * chore: add newline to end of TwoFactorAuthenticationTest file * refactor: enhance TwoFactor UI with conditional enable button logic, refine recovery codes handling * refactor: enhance TwoFactor UI with conditional enable button logic, refine recovery codes handling * refactor: inline two-factor authentication composable logic into TwoFactor component to simplify structure * refactor: remove unused `ref` and `focus` logic from Input component to simplify structure * refactor: enhance two-factor authentication flow with middleware checks, improved UI spacing, and expanded test coverage * refactor: simplify TwoFactor component with async/await, refine recovery codes handling, and standardize UI consistency * refactor: reset setup data on modal close, improve form handling, and simplify PinInput structure * refactor: add reusable reset methods for reactive states, simplify TwoFactor logic, and enhance PinInput handling * fix: formatting issue * fix: conditionally apply password confirmation middleware * chore: update lock file * fix: make component reactive * wip * refactor: split the component * refactor: use composable * refactor: remove redundant type definition * refactor: remove custom useClipboard composable * refactor: simplify recovery codes visibility logic * fix: merge issues * refactor: update two-factor authentication forms to use route helpers * refactor: test * refactor: improve two-factor authentication tests and enhance readability * refactor: update two-factor authentication tests for consistency and improve code readability * wip * Move conditional middleware from route to controller * Fix tests to be consistent based on config * Remove comments * refactor: simplify toggleRecoveryCodesVisibility function signature * remove duplicate type defination * fix type definition * More Fixes * fix types * fix wayfinder routes * refactor ui to use defineModal and remove unnecessary things * remove unneeded async attribute * remove redundant attribute action * fix: finish state * fix: merge conflicts * state cleanup * fix typo * use arrow functions * Move trait to form-request * Formatting * various formatting tweaks * Update TwoFactorSetupModal.vue * Bump Fortify * Use ensure state is valid from Fortify * Refactor TwoFactorAuthenticationRequest namespace * Formatting * Formatting * Refactor Test * formatting * Fix Text Jarring Issue * Add hasSetupData to avoid enabling 2FA again * Update useTwoFactorAuth.ts --------- Co-authored-by: Taylor Otwell <[email protected]>
Integrate PestPHP 4 Browser Tests
Update .gitattributes
- Axios is vulnerable to DoS attack through lack of data size check - GHSA-4hjh-wcwx-xvwj - Vite middleware may serve files starting with the same name with the public directory - GHSA-g4jq-h2w9-997c - Vite's `server.fs` settings were not applied to HTML files - GHSA-jqfw-vq24-v9c3
The issue was caused by a too-strict PHPDoc that assumed the retrieved user is always a User. However, `retrieveByCredentials()` can return null. This aligns the docblock with the actual return type, making the subsequent null/credential checks type-safe.
Bump dependencies to solve npm audit issues
Standardise routes name across starter kits
Correct LoginRequest retrieved user type to allow null
Update eslint.config.js
Use and show the icon in the sidebarNavItems in the settings sidebar
Change Prettier print width from 150 to 80
# Conflicts: # resources/js/composables/useTwoFactorAuth.ts
Add an error state in `useTwoFactorAuth.ts`
Add data-test attribute to sidebar menu button for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.