Skip to content

Fix sidebar functionality by using correct type in NavMain #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix sidebar functionality by using correct type in NavMain #27

merged 1 commit into from
Feb 24, 2025

Conversation

kaarelsirel
Copy link
Contributor

At the moment the sidebar links are not functioning at all.

This pull request fixes the type error in AppSidebar.vue by using the imported NavItem type and correct property names in NavMain.vue.

tnylea
tnylea approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This was a recent change and this .url never got changed to .href.

Appreciate it!

@tnylea tnylea mentioned this pull request Feb 24, 2025
Closed
@taylorotwell taylorotwell merged commit 70c929c into laravel:main Feb 24, 2025
2 checks passed
@kaarelsirel kaarelsirel deleted the fix-app-sidebar-type-error branch February 24, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tnylea tnylea tnylea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaarelsirel @tnylea @taylorotwell