Skip to content

Conversation

fftfaisal
Copy link
Contributor

This PR fix breadcrumb not displayed due to unknown breadcrumb component loaded in the AppHeader.vue for the Header Layout.

Step to Reproduce

Add 2 items in the breadcrumb items on the any page component.
Then it will display the breadcrumb

Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering this @fftfaisal.

Looks good. Appreciate the PR 👍

@tnylea
Copy link
Contributor

tnylea commented Feb 24, 2025

Hey @fftfaisal,

After taking a look further at this, I thought it would be best if we separated the breadcrumb loop into its own component called Breadcrumbs. This way if you are using the Header or the Sidebar layout, you can use the same breadcrumb component.

Thanks again. We'll get this merged in soon 👏

@fftfaisal
Copy link
Contributor Author

Hey @fftfaisal,

After taking a look further at this, I thought it would be best if we separated the breadcrumb loop into its own component called Breadcrumbs. This way if you are using the Header or the Sidebar layout, you can use the same breadcrumb component.

Thanks again. We'll get this merged in soon 👏

Yes. That's a good idea. Thank you.

@taylorotwell taylorotwell merged commit aba3270 into laravel:main Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants