Skip to content

Fix: Vue type checking for AvatarImage component #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix: Vue type checking for AvatarImage component #33

merged 1 commit into from
Feb 25, 2025

Conversation

fftfaisal
Copy link
Contributor

This PR fix browser console warning when AvatarImage component src prop was undefined.
Uses Same as logic from UserInfo component but without using computed property

2025-02-25_033024

tnylea
tnylea approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you.

@taylorotwell taylorotwell merged commit c22e63e into laravel:main Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tnylea tnylea tnylea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fftfaisal @tnylea @taylorotwell