Skip to content

Fix ShareData type #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix ShareData type #40

merged 1 commit into from
Feb 25, 2025

Conversation

@thewebartisan7
Copy link
Contributor

@thewebartisan7 thewebartisan7 commented Feb 25, 2025 •
edited
Loading

I notice this type issue:

Screenshot 2025-02-25 at 09 20 44

I am not sure why ShareData doesn't satisfy PageProps since PageProps is of type { [k: string]: unknown }. But with this PR it seems to be fixed.

tnylea
tnylea approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just tested it out. Looks good 👍

@taylorotwell taylorotwell merged commit 7fd0944 into laravel:main Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tnylea tnylea tnylea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thewebartisan7 @tnylea @taylorotwell