Skip to content

Conversation

@ottoszika
Copy link

This PR adds esbuild platform-specific binaries back. I think these were accidentally removed by 097e273 and only darwin-arm64 was left, so npm install on Apple Silicon may work, but on other platforms not.

@tnylea
Copy link
Contributor

tnylea commented Feb 26, 2025

Can you explain to me how this is generated.

Does npm install need to be run on a machine that is not Apple Silicon in order to keep the darwin-arm64. I'm trying to understand how we can prevent this from happening again because the only file in this PR is the package-lock.json file.

@tnylea tnylea added the Awaiting User Response Waiting for developers response label Feb 26, 2025
@ottoszika
Copy link
Author

@tnylea These dependencies are from the optionalDependencies of esbuild (https://github.com/evanw/esbuild/blob/v0.25.0/npm/esbuild/package.json#L20).

if we start with a clean project by running npm init -y && npm install esbuild we can see that the package-lock.json will contain these dependencies. I don't know what happened exaclty. Maybe the lockfile was regenerated (deleted and added back through npm install). 🤔

@taylorotwell
Copy link
Member

Fixed locally and pushed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting User Response Waiting for developers response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants