Skip to content

fix: double anchor tag in Breadcrumbs #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix: double anchor tag in Breadcrumbs #59

merged 1 commit into from
Feb 28, 2025

Conversation

@ibrunotome
Copy link
Contributor

Without as-child, this will render double nested <a> tags.

@ibrunotome
Update Breadcrumbs.vue
4b22857 
Without `as-child`, this will render double nested `<a>` tags.
@ibrunotome ibrunotome changed the title Update Breadcrumbs.vue fix: double anchor tag in Breadcrumbs Feb 26, 2025
@tnylea tnylea added the Approved Approved for merge label Feb 27, 2025
tnylea
tnylea approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👏

@taylorotwell taylorotwell merged commit c2b9d02 into laravel:main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tnylea tnylea tnylea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved Approved for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibrunotome @tnylea @taylorotwell