Wrong NavType prop #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

antoniofrignani wants to merge 1 commit into laravel:main from antoniofrignani:patch-1

antoniofrignani commented Feb 27, 2025

AppSidebar.vue footerNavItems sets url as the hyperlink, but it is defined as href in the NavItem props.

    {
        title: 'Github Repo',
        url: 'https://github.com/laravel/vue-starter-kit',
        icon: Folder,
    },


          Wrong NavType prop

e1369c8

Contributor

tnylea commented Feb 28, 2025

Thanks @antoniofrignani

We have set this to be href on the main branch: https://github.com/laravel/vue-starter-kit/blob/main/resources/js/components/AppSidebar.vue#L22. Appreciate it!

tnylea closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet