Skip to content

Conversation

lokomilo
Copy link
Contributor

@lokomilo lokomilo commented Mar 1, 2025

The included GitHub test workflow runs php artisan ziggy:generate which creates the resources/js/ziggy.js file. This generated file would have its formatting changed when running Prettier with the included config.

This means that if the user adds a formatting check as part of their test workflow (e.g. prettier --check) it will fail.

As the file is auto-generated there should not be any issues ignoring it when manually running Prettier outside of the test workflow.

Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for the description on why this is needed.

@tnylea tnylea added the Approved Approved for merge label Mar 3, 2025
@taylorotwell taylorotwell merged commit 41eb194 into laravel:main Mar 4, 2025
2 checks passed
D4ve-R pushed a commit to D4ve-R/vue-starter-kit that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants