Fixing Inertia SSR errors #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeyMckenzie
reviewed
Mar 4, 2025
|
|
||
| return [ | ||
| ...parent::share($request), | ||
| return array_merge(parent::share($request), [ |
There was a problem hiding this comment.
Is this array_merge() necessary? The React version doesn't use it, though either the spread or the merge will accomplish the same thing. Just wanted to double check so we can keep consistency between the React/Vue templates.
There was a problem hiding this comment.
Right you are, we could use the spread operator here. Thanks!
JoeyMckenzie
reviewed
Mar 4, 2025
resources/js/ssr.tsx
Outdated
There was a problem hiding this comment.
Should this file be ssr.ts instead? There's no JSX being used, so probably not necessary to have that as the file type.
There was a problem hiding this comment.
Good catch. I'll get that updated.
D4ve-R
pushed a commit
to D4ve-R/vue-starter-kit
that referenced
this pull request
Mar 11, 2025
* Adding initial SSR fixes * fixing warning messages in SSR * Adding updates to ssr file to include global route var * Adding dev:ssr command * Adding light/dark mode fixes to support cookies and localstorage * updating the intertia return array * formatting * run formatter --------- Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the warnings and errors when running the starter kit using Inertia SSR.
Test this out by running:
You can also run:
Which is a new script that's added to the composer.json to run the SSR functionality.
You can also test this out by
disabling javascriptin the browser. If it's SSR, everything will work with Javascript Disabled; otherwise if you are running the defaultcomposer run devthe pages will not render if you disable javascript; rightfully so.This PR has a similar PR on the react starter kit: laravel/react-starter-kit#53