Use shadcn built-in check for sidebar state #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thanks @JoeyMckenzie. |
|
Small issue on this one. The Laravel starter kit default behavior is for the sidebar to be open the first time the user loads the page. This PR would collapse it by default. In order to keep the existing behavior the HandleInertiaRequests middleware edit should be: 'sidebarOpen' => ! $request->hasCookie('sidebar_state') || $request->cookie('sidebar_state') === 'true',Otherwise, awesome PR! |
|
@stephenhowells Good catch. I've went ahead and made that update so that way the sidebar is open by default 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadcn includes built-in functionality to determine the sidebar state via cookie, so the local component logic utilizing local storage is unnecessary. I've also renamed the cookie name in
utils.tsto reflect what's in the documentation.This change is the Vue version of the same change being made to the React starter kit.