-
Notifications
You must be signed in to change notification settings - Fork 233
Tailwind V4 Upgrade 💾 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little comment about oklch colors and autoprefixer plugin.
Yes, in css: {
postcss: {
plugins: [tailwindcss, autoprefixer],
},
}, can be removed when using the Tailwind Vite plugin installation Also, i think some shadcn components got updates in version 2 and are still not updated in this PR, it can be done running this in the console:
Those are all the components we are using for the Vue starter kit |
NPM dependencies And shadcn/vue 2 now uses When installed that also needs to be adjusted in @import "tw-animate-css"; instead of @plugin 'tailwindcss-animate'; |
This is going to be 🔥 |
Thanks @Bosphoramus for all the feedback. It looks like many of the components have been updated since the first release of ShadCN Vue 2.0. I've updated them and re-checked that all the layouts look correct. I've also swapped out Feel free to send over any additional feedback that you implemented in your version of the upgrade and I'll take a look into it. Appreciate it! |
|
||
@layer base { | ||
* { | ||
@apply border-border outline-ring/50; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this outline-ring/50
not just added to the previous @layer base
a few lines above?
This PR includes the upgrade to Tailwind CSS v4.
You can find more details about the upgrade process here: https://www.shadcn-vue.com/docs/tailwind-v4.html. A few additional modifications have been made to the styles and sidebar to ensure everything looks good. I experienced a few layout issues that might have resulted from upgrading from ShadCN Vue 1 to v2 with the latest tailwind.
I reviewed the starter kit manually to ensure everything looks the same. Here's a quick screencast of these tests.
tailwind-v4.mp4
Everything seems to be working as it did before; however, this new version now includes the new Reka UI lib along with the latest version of Tailwind 👏