Skip to content

Conversation

basharalhato
Copy link

🛠 Fix: Active Links Not Working with URL Queries or Parameters

Issue:
Active navigation links were not properly highlighted when the current URL included query strings or parameters (e.g., /dashboard?tab=overview or /profile/123). This confused the UI, as the user would not see the expected active state on the corresponding nav link.

Cause:
The current logic for determining active links was performing an exact pathname match, failing when additional query parameters or dynamic segments were present.

@tnylea
Copy link
Contributor

tnylea commented Apr 14, 2025

Thanks for the PR. I don't think we want to pass components/component names inside of the mainNavItems array.

In fact we are going to be adding some modifications to the starter kit to include Laravel Wayfinder that will resolve things like this.

Closing for now and will be adding some updates to resolve this soon. Thanks!

@tnylea tnylea closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants