WIP

Author: tauseefsshah

app/Console/Commands/SyncArticleImages.php

@@ -47,7 +47,11 @@ public function handle(): void
 
     protected function shouldBeSynced(Article $article): bool
     {
-        if ($article->hero_image && ! $article->hasHeroImage()) {
+        if (!$article->hero_image) {
+            return false;
+        }
+
+        if ($article->hero_image && $article->hasHeroImage()) {
             return false;
         }
 

tests/Integration/Commands/SyncArticleImagesTest.php

@@ -10,12 +10,18 @@
 uses(DatabaseMigrations::class);
 
 
-test('hero image url is updated for published articles with hero image', function () {
+test('hero image url and author information is updated for published articles with hero image', function () {
     Http::fake(function () {
         return [
             'urls' => [
                 'raw' => 'https://images.unsplash.com/photo-1584824486509-112e4181ff6b?ixid=M3w2NTgwOTl8MHwxfGFsbHx8fHx8fHx8fDE3Mjc2ODMzMzZ8&ixlib=rb-4.0.3'
-            ]
+            ],
+            'user' => [
+                'name' => 'Erik Mclean',
+                'links' => [
+                    'html' => 'https://unsplash.com/@introspectivedsgn',
+                ]
+            ],
         ];
     });
 
@@ -29,11 +35,12 @@
 
     $article->refresh();
 
-    expect($article->heroImage())->toBeUrl();
     expect($article->heroImage())->toContain('https://images.unsplash.com/photo-1584824486509-112e4181ff6b');
+    expect($article->hero_image_author_name)->toBe('Erik Mclean');
+    expect($article->hero_image_author_url)->toBe('https://unsplash.com/@introspectivedsgn');
 });
 
-test('hero image url is not updated for published articles with no hero image', function () {
+test('hero image url and author information is not updated for published articles with no hero image', function () {
     $article = Article::factory()->create([
         'submitted_at' => now(),
         'approved_at' => now(),
@@ -44,4 +51,6 @@
     $article->refresh();
 
     expect($article->hero_image_url)->toBe(null);
-});
+    expect($article->hero_image_author_name)->toBe(null);
+    expect($article->hero_image_author_url)->toBe(null);
+})->only();