Skip to content

Remove cython from installation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erezsh merged 5 commits into from
Jul 15, 2025
Merged

Remove cython from installation #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5f09fd
Remove cython from installation requirement
tiagocoutinho Jul 4, 2025
13aab39
Delay import doesn't do anything
tiagocoutinho Jul 4, 2025
ae25ebc
Update github actions upload-artifact
tiagocoutinho Jul 5, 2025
5dc9e8f
Update github actions download-artifact
tiagocoutinho Jul 7, 2025
200429d
Merge artifacts
tiagocoutinho Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ jobs:
python -m pytest --cov=$MOD_NAME $MOD_DPATH ../tests
cd ..
- name: Upload sdist artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheels
name: wheels-src
path: ./wheelhouse/*.tar.gz

build_binary_wheels:
Expand All @@ -53,21 +53,21 @@ jobs:
strategy:
matrix:
os: ["windows-latest", "ubuntu-latest", "macOS-latest"]
cibw_skip: ["*-win32"]
cibw_skip: ["win32"]
arch: [auto]
include:
- os: windows-latest
arch: auto
cibw_skip: '*-win_amd64'
cibw_skip: 'win_amd64'
steps:
- name: Checkout source
uses: actions/checkout@v4
- name: Enable MSVC 64bit
uses: ilammy/msvc-dev-cmd@v1
if: matrix.os == 'windows-latest' && matrix.cibw_skip == '*-win32'
if: matrix.os == 'windows-latest' && matrix.cibw_skip == 'win32'
- name: Enable MSVC 32bit
uses: ilammy/msvc-dev-cmd@v1
if: matrix.os == 'windows-latest' && matrix.cibw_skip == '*-win_amd64'
if: matrix.os == 'windows-latest' && matrix.cibw_skip == 'win_amd64'
with:
arch: x86
- name: Build binary wheels
Expand All @@ -78,7 +78,7 @@ jobs:
env:
CIBW_BUILD_VERBOSITY: 1
#CIBW_TEST_COMMAND: pytest
CIBW_SKIP: ${{ matrix.cibw_skip }}
CIBW_SKIP: "*-${{ matrix.cibw_skip }}"
CIBW_ARCHS_LINUX: ${{ matrix.arch }}
- name: Show built files
shell: bash
Expand Down Expand Up @@ -107,12 +107,13 @@ jobs:
name: Codecov Upload
with:
file: ./tests/coverage.xml
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
name: Upload wheels artifact
with:
name: wheels
name: wheels-${{ matrix.os }}-${{ matrix.cibw_skip }}
path: ./wheelhouse/*.whl


publish_wheels:
name: Publish Wheels
runs-on: ubuntu-latest
Expand All @@ -121,11 +122,17 @@ jobs:
- build_sdist

steps:
- name: Merge wheels
uses: actions/upload-artifact/merge@v4
with:
name: wheels
pattern: wheels-*

- name: Checkout source
uses: actions/checkout@v4

- name: Download wheels and sdist
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: wheels
path: wheelhouse
Expand Down
15 changes: 3 additions & 12 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,7 @@

# python .\setup.py build_ext --inplace


# Delayed import; https://stackoverflow.com/questions/37471313/setup-requires-with-cython
try:
from Cython.Build import cythonize
except ImportError:

def cythonize(*args, **kwargs):
from Cython.Build import cythonize

return cythonize(*args, **kwargs)
Copy link
Contributor Author

@tiagocoutinho tiagocoutinho Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not doing anything that fixes installation without cython installed.
The real fix was on pyproject.toml by adding cython as build dependency

from Cython.Build import cythonize


def parse_description():
Expand All @@ -38,8 +29,8 @@ def parse_description():
packages=find_packages(),
ext_modules=cythonize("lark_cython/*.pyx"), # accepts a glob pattern
requires=["Cython"],
install_requires=["lark>=1.1.7", "cython>=3.0,<3.1", "Cython>=3.0,<3.1"],
setup_requires=["Cython"],
install_requires=["lark>=1.1.7"],
setup_requires=["Cython>=3.0,<3.1"],
author="Erez Shinan",
author_email="lark@erezsh.com",
description="A Lark plugin that optimizes LALR parsing using Cython",
Expand Down
Loading