Remove dim attribute before calling bind_rows()#109
Merged
larmarange merged 2 commits intolarmarange:mainfrom Dec 21, 2025
Merged
Remove dim attribute before calling bind_rows()#109larmarange merged 2 commits intolarmarange:mainfrom
dim attribute before calling bind_rows()#109larmarange merged 2 commits intolarmarange:mainfrom
Conversation
17 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 83.41% 83.37% -0.05%
==========================================
Files 22 22
Lines 1924 1931 +7
==========================================
+ Hits 1605 1610 +5
- Misses 319 321 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for the report and the PR. I will incorporate it and release a new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on the next vctrs release, targeted for Jan 15, and this package came up in our revdep analysis.
vctrs::obj_is_list()no longer returnsTRUEfor list arrays, which means that you can't pass a list array to things likedplyr::bind_rows(). Unfortunatelyby()returns one of these, so you must undim the result first.