Skip to content

Remove dim attribute before calling bind_rows()#109

Merged
larmarange merged 2 commits intolarmarange:mainfrom
DavisVaughan:fix/vctrs-compat
Dec 21, 2025
Merged

Remove dim attribute before calling bind_rows()#109
larmarange merged 2 commits intolarmarange:mainfrom
DavisVaughan:fix/vctrs-compat

Conversation

@DavisVaughan
Copy link
Contributor

We are working on the next vctrs release, targeted for Jan 15, and this package came up in our revdep analysis.

vctrs::obj_is_list() no longer returns TRUE for list arrays, which means that you can't pass a list array to things like dplyr::bind_rows(). Unfortunately by() returns one of these, so you must undim the result first.

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.37%. Comparing base (b2264f2) to head (70a15b0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
R/geom_connector.R 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   83.41%   83.37%   -0.05%     
==========================================
  Files          22       22              
  Lines        1924     1931       +7     
==========================================
+ Hits         1605     1610       +5     
- Misses        319      321       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larmarange
Copy link
Owner

Thanks for the report and the PR. I will incorporate it and release a new version.
Best regards

@larmarange larmarange merged commit 142c29f into larmarange:main Dec 21, 2025
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants