fix #335 : Standardize nan to NaN in all docstrings. #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdementen
reviewed
Apr 11, 2019
|
otherwise LGTM (and should not even require a review) |
alixdamman
force-pushed
the
master
branch
3 times, most recently
from
9264074 to
01669f2
Compare
|
Is there anything left to do before you can merge this? |
|
I am still not sure about the strategy to adopt with the NaN in the documentation. I prefer to move this issue to the 0.31 milestone |
|
What's the problem exactly? |
|
If we except the doctests, both Numpy and Pandas use In our case, since the raw data are stored in Numpy ndarray, I think we should the same strategy as Numpy. |
alixdamman
force-pushed
the
335_standardize_nan_in_docstrings
branch
from
8639e2c to
ec739af
Compare
…ep nan when printing values. (same as Numpy).
alixdamman
force-pushed
the
335_standardize_nan_in_docstrings
branch
from
ec739af to
a62c32d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose the same logic as Numpy: use
NaNin docstrings andnanwhen printing values.Pandas chose to use NaN everywhere.