Skip to content

Conversation

alixdamman
Copy link
Collaborator

No description provided.

…y when dumping/loading Axis and Group objects to/from HDF files (to avoid huge size hdf files)
@alixdamman alixdamman added this to the 0.31 milestone Aug 5, 2019
@alixdamman alixdamman requested a review from gdementen August 5, 2019 10:14
@alixdamman
Copy link
Collaborator Author

needs a changelog?

Copy link
Contributor

@gdementen gdementen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only nitpick is that I find the attribute "kind" not very telling. maybe dtype_kind of data_kind or ?

@gdementen
Copy link
Contributor

gdementen commented Aug 5, 2019

For the changelog, if the only consequence is to make sessions with standalone "unicode axes" (or groups) smaller, then probably not (because those or not used yet AFAIK). If it also has an impact on arrays with such axes, then yes.

@alixdamman alixdamman merged commit 053e7be into larray-project:master Aug 5, 2019
@alixdamman alixdamman deleted the 788_string_to_bytes_hdf branch August 5, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants