issue 611: rename Larray class as Array #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixdamman
force-pushed
the
611_rename_LArray_class_as_Array
branch
from
a1ead7e to
667e62b
Compare
|
The:
are the most important commits to review. |
gdementen
approved these changes
Oct 9, 2019
| class LArray(Array): | ||
| def __init__(self, *args, **kwargs): | ||
| warnings.warn("LArray has been renamed as Array.", FutureWarning, stacklevel=2) | ||
| Array.__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
can't we use LArray = renamed_to(Array, 'LArray') instead?
There was a problem hiding this comment.
rename_to return a function and not a class. In addition, the printed warning message would have been LArray() is deprecated. Use Array() instead, i.e. with ( ) after class names.
There was a problem hiding this comment.
Calling a function and a class is essentially the same thing in Python (they are both callables) and I don't see the problem with that warning message.
alixdamman
force-pushed
the
611_rename_LArray_class_as_Array
branch
from
9256ef7 to
29c0d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for PR #809 to be merged before to finish this PR.