Skip to content

Conversation

alixdamman
Copy link
Collaborator

No description provided.

@alixdamman alixdamman added this to the 0.32 milestone Oct 31, 2019
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@alixdamman
Copy link
Collaborator Author

OK to merge?

@gdementen
Copy link
Contributor

Sure. Maybe convert pandas.rst too?

@alixdamman alixdamman force-pushed the 821_make_getting_started_rst_file_a_notebook branch from 49339ff to 20596ea Compare November 7, 2019 10:46
Copy link
Contributor

@gdementen gdementen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…rial notebooks except in getting_started.ipynb
…py.dtype size changed) in all tutorial notebooks
@alixdamman alixdamman merged commit 3e6d798 into larray-project:master Nov 7, 2019
Copy link
Contributor

@gdementen gdementen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (for real, this time). Let's hope the warning is not present on readthedocs.

@alixdamman alixdamman deleted the 821_make_getting_started_rst_file_a_notebook branch November 7, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants