Replace DATA_PTR and Data_Get_Struct by SWIG_ConvertPtr#86
Merged
Conversation
Mixing ruby functions and SWIG functions to access Ruby/C++ objects is bad practice. It relies on a particular expectation of how SWIG maps C++ objects to Ruby objects. This commit changes the code to use SWIG functions only and to not use raw Ruby functions to access SWIG mapped objects. Also change the flag of ConvertPtr to the SWIG provided constant SWIG_POINTER_DISOWN, to make it more clear, that the object will be deleted by the object it was assigned to. The compiler deprecation warning is re-enabled, since they do no longer appear when built with SWIG with the following patch: swig/swig#3326 Fix type conversions of Array<FXPoint>, Array<FXRectangle>, Array<FXSegment> and Array<FXArc> to raise an error on type mismatch. This wasn't checked before and could lead to invalid memory access.
…TER_OWN, to make it clearer.
Because SWIG-ownership gets dropped when the Fox object is assigned to some other Fox object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixing ruby functions and SWIG functions to access Ruby/C++ objects is bad practice. It relies on a particular expectation of how SWIG maps C++ objects to Ruby objects.
This commit changes the code to use SWIG functions only and to not use raw Ruby functions to access SWIG mapped objects.
Also change the flag of ConvertPtr to the SWIG provided constant SWIG_POINTER_DISOWN, to make it more clear, that the object will be deleted by the object it was assigned to.
The compiler deprecation warning is re-enabled, since they do no longer appear when built with SWIG with the following patch:
swig/swig#3326
Fix type conversions of Array<FXPoint>, Array<FXRectangle>, Array<FXSegment> and Array<FXArc> to raise an error on type mismatch. This wasn't checked before and could lead to invalid memory access.