Clubb coriolis cam#20
Open
HingOng wants to merge 6 commits intolarson-group:clubb_4ncar_20240605_73d60f6_gpufixesfrom
Open
Clubb coriolis cam#20HingOng wants to merge 6 commits intolarson-group:clubb_4ncar_20240605_73d60f6_gpufixesfrom
HingOng wants to merge 6 commits intolarson-group:clubb_4ncar_20240605_73d60f6_gpufixesfrom
Conversation
vlarson
requested changes
Aug 7, 2025
Contributor
vlarson
left a comment
vlarson
left a comment
There was a problem hiding this comment.
I'm impressed by how ably you detected so many of the CLUBB coding conventions! I can make the suggested changes if you don't want to or don't have time.
| dt ! Timestep length [s] | ||
|
|
||
| real( kind = core_rknd ), dimension(ngrdcol), intent(in) :: & | ||
| fcory ! Nontraditional Coriolis parameter [s^-1] |
Contributor
There was a problem hiding this comment.
Could you please give a few lines of description of fcory? How does it differ from fcor? Qualitatively, how does it vary from equator to pole?
| !####################################################################### | ||
| subroutine advance_clubb_core( gr, nz, ngrdcol, & ! intent(in) | ||
| l_implemented, dt, fcor, sfc_elevation, & ! intent(in) | ||
| l_implemented, dt, fcor, fcory, sfc_elevation, & ! intent(in) |
Contributor
There was a problem hiding this comment.
For readability, could you please rename "fcory" to "fcor_y"?
| end if | ||
|
|
||
|
|
||
| if ( l_nontraditional_Coriolis ) then |
Contributor
There was a problem hiding this comment.
This flag will need to be fed into the flags namelist:
| rtm_min = epsilon( rtm_min ), & ! Value below which rtm will be nudged [kg/kg] | ||
| rtm_nudge_max_altitude = 10000._core_rknd ! Highest altitude at which to nudge rtm [m] | ||
|
|
||
| integer, parameter :: & |
Contributor
There was a problem hiding this comment.
How did this code change end up in your pull request? Do you happen to know? I don't see this line in the master branch.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is similar to "clubb_Coriolis" but supports coupling to NCAR CAM